Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add keymaps e2e test #1850

Merged
merged 2 commits into from
Oct 27, 2022
Merged

test: add keymaps e2e test #1850

merged 2 commits into from
Oct 27, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Oct 26, 2022

Types

  • ⏱ Tests

Background or solution

支持如下测试案例:

  • 支持通过快捷键 CMD+K CMD+S 打开设置面板
  • 支持通过左侧设置按钮中的 Keyboard Shortcuts 菜单打开设置面板
  • 打开设置面板,修改保存文件功能快捷键为 CMD+SHIF+S,原有 CMD+S 快捷键失效,使用 CMD+SHIF+S 后可以正常进行文件保存动作

Changelog

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 57.59% // Head: 57.58% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (17c4563) compared to base (2929f97).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
- Coverage   57.59%   57.58%   -0.01%     
==========================================
  Files        1285     1285              
  Lines       80216    80236      +20     
  Branches    16808    16811       +3     
==========================================
+ Hits        46197    46203       +6     
- Misses      30942    30955      +13     
- Partials     3077     3078       +1     
Flag Coverage Δ
jsdom 52.33% <0.00%> (-0.01%) ⬇️
node 15.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-browser/src/layout/layout.ts 42.50% <0.00%> (ø)
packages/debug/src/browser/model/debug-thread.ts 75.00% <0.00%> (-7.76%) ⬇️
packages/debug/src/browser/model/debug-source.ts 81.66% <0.00%> (-5.84%) ⬇️
packages/monaco/src/browser/schema-registry.ts 68.88% <0.00%> (-2.23%) ⬇️
...erences/src/browser/preference-settings.service.ts 75.00% <0.00%> (-0.63%) ⬇️
...kages/theme/src/browser/workbench.theme.service.ts 71.18% <0.00%> (-0.58%) ⬇️
packages/debug/src/browser/debug-session.ts 10.84% <0.00%> (-0.07%) ⬇️
packages/debug/src/common/debug-session.ts 100.00% <0.00%> (ø)
packages/theme/src/common/color-tokens/debug.ts 100.00% <0.00%> (ø)
packages/monaco-enhance/src/browser/zone-widget.ts 46.56% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 118c190 into main Oct 27, 2022
@erha19 erha19 deleted the test/e2e/keymaps-test branch October 27, 2022 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants