Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove activityBar badge border #1856

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

yantze
Copy link
Member

@yantze yantze commented Oct 26, 2022

Types

  • 💄 Style Changes

Background or solution

Activity Bar 的 badge 加了 border 后分散注意力,2.20 是突然出现的,感觉可以去掉
image
image

Changelog

chore: 移除 Activity Bar 的 badge 的 border 样式

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 57.57% // Head: 57.57% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ac98579) compared to base (69ba8b8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1856   +/-   ##
=======================================
  Coverage   57.57%   57.57%           
=======================================
  Files        1285     1285           
  Lines       80236    80236           
  Branches    16811    16811           
=======================================
+ Hits        46196    46198    +2     
+ Misses      30961    30960    -1     
+ Partials     3079     3078    -1     
Flag Coverage Δ
jsdom 52.33% <ø> (+<0.01%) ⬆️
node 15.90% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/utils/src/strings.ts 39.26% <0.00%> (-0.22%) ⬇️
...kages/theme/src/browser/workbench.theme.service.ts 71.75% <0.00%> (+0.57%) ⬆️
packages/monaco/src/browser/schema-registry.ts 71.11% <0.00%> (+2.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit a01260d into main Oct 26, 2022
@erha19 erha19 deleted the chore/remove-activity-bar-badge-border branch October 26, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants