Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 批量替换时已打开的文件未自动保存 #1948

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

AEPKILL
Copy link
Contributor

@AEPKILL AEPKILL commented Nov 9, 2022

Types

  • 🐛 Bug Fixes

Background or solution

this close: #1221

Changelog

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the 🐞 bug Something isn't working label Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 57.61% // Head: 57.61% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8bf3693) compared to base (055c5e8).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1948   +/-   ##
=======================================
  Coverage   57.61%   57.61%           
=======================================
  Files        1286     1286           
  Lines       80534    80540    +6     
  Branches    16855    16856    +1     
=======================================
+ Hits        46399    46407    +8     
+ Misses      31050    31049    -1     
+ Partials     3085     3084    -1     
Flag Coverage Δ
jsdom 52.37% <60.00%> (+<0.01%) ⬆️
node 15.88% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/search/src/browser/search.service.ts 41.16% <ø> (ø)
packages/search/src/browser/search-tree.service.ts 35.92% <25.00%> (+0.20%) ⬆️
packages/search/src/browser/replace.ts 70.96% <83.33%> (+1.73%) ⬆️
packages/core-common/src/node/port.ts 44.77% <0.00%> (-2.99%) ⬇️
packages/utils/src/buffer.ts 33.72% <0.00%> (+2.90%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 requested a review from bytemain November 10, 2022 02:10
@bytemain bytemain changed the title fix: 批量替换时已打开的文件未自动保存(#1221) fix: 批量替换时已打开的文件未自动保存 Nov 10, 2022
Copy link
Member

@bytemain bytemain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@yantze yantze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19
Copy link
Member

erha19 commented Nov 10, 2022

@AEPKILL thanks for your contribution ~

This PR will be published on the v2.22 iteration, if you want to use it, you can tell us and we will publish an RC version for you.

@erha19 erha19 merged commit e7284d9 into opensumi:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 批量替换时已打开的文件未自动保存
5 participants