Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support useVSCodeWorkspaceConfiguration config #1974

Merged
merged 4 commits into from
Nov 21, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Nov 15, 2022

Types

  • 🎉 New Features

Background or solution

close #1972

Changelog

support useVSCodeWorkspaceConfiguration config

@github-actions github-actions bot added the 🎨 feature feature required label Nov 15, 2022
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 57.49% // Head: 57.48% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (df2f683) compared to base (0a55bdf).
Patch coverage: 74.28% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1974      +/-   ##
==========================================
- Coverage   57.49%   57.48%   -0.01%     
==========================================
  Files        1286     1286              
  Lines       80542    80555      +13     
  Branches    16853    16856       +3     
==========================================
+ Hits        46306    46310       +4     
- Misses      31120    31127       +7     
- Partials     3116     3118       +2     
Flag Coverage Δ
jsdom 52.24% <74.28%> (-0.01%) ⬇️
node 15.88% <8.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/task/src/browser/index.ts 0.00% <0.00%> (ø)
...ages/task/src/browser/task-preferences.provider.ts 0.00% <0.00%> (ø)
...c/browser/abstract-resource-preference-provider.ts 80.00% <33.33%> (-2.56%) ⬇️
...owser/src/preferences/preference-configurations.ts 86.11% <100.00%> (ø)
...es/core-common/src/preferences/preference-scope.ts 65.62% <100.00%> (+1.10%) ⬆️
packages/debug/src/browser/index.ts 95.65% <100.00%> (ø)
...r/preferences/launch-folder-preference-provider.ts 85.71% <100.00%> (ø)
...ces/src/browser/folder-file-preference-provider.ts 95.23% <100.00%> (ø)
...rences/src/browser/folders-preferences-provider.ts 67.13% <100.00%> (ø)
packages/preferences/src/browser/index.ts 91.66% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 added this to the 2.22 milestone Nov 16, 2022
@erha19 erha19 merged commit a636bfa into main Nov 21, 2022
@erha19 erha19 deleted the feat/support-use-vscode-workspace-configuration branch November 21, 2022 06:56
@bytemain bytemain mentioned this pull request Mar 28, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 提供一个配置用于开启对项目内 .vscode 目录配置的识别及内容合并
2 participants