Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove package vscode-languageserver-protocol #1988

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

yantze
Copy link
Member

@yantze yantze commented Nov 18, 2022

Types

  • 🪚 Refactors

Background or solution

编译后有不同版本的 vscode-jsonrpc 存在。由于 vscode-languageserver-protocol 模块引入了另外一个 vscode-jsonrpc 包导致的多个同类的包。

现在用 isDocumentFilter 替代这个方法,优化编译后的包体积,减少大概 97KB,减少 0.9% 的体积。

  bundle.js size (production)
before 10804079
after 10706805

使用 tools/electron 来进行的编译

Changelog

refactor: remove package vscode-languageserver-protocol

@github-actions github-actions bot added the ⚙️ refactor Refactor code label Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 57.49% // Head: 57.49% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (04d01b4) compared to base (85aff8c).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1988      +/-   ##
==========================================
- Coverage   57.49%   57.49%   -0.01%     
==========================================
  Files        1286     1286              
  Lines       80543    80546       +3     
  Branches    16853    16854       +1     
==========================================
  Hits        46311    46311              
- Misses      31117    31119       +2     
- Partials     3115     3116       +1     
Flag Coverage Δ
jsdom 52.25% <80.00%> (-0.01%) ⬇️
node 15.88% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ion/src/browser/vscode/api/main.thread.language.ts 57.27% <50.00%> (ø)
packages/extension/src/common/vscode/model.api.ts 84.72% <100.00%> (+0.66%) ⬆️
packages/utils/src/buffer.ts 33.13% <0.00%> (-1.75%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Aaaaash Aaaaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 27de079 into main Nov 21, 2022
@erha19 erha19 deleted the refactor/simpify-vscode-languageserver-protocol-helper branch November 21, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants