Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support base64 icon on editor glyphMargin and treeview #2010

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Nov 24, 2022

Types

  • 🎉 New Features

Background or solution

Bookmarks 插件在升级到 13.0+ 版本后,采用了 base64 图标,原有不支持导致新版本插件显示异常

支持前:

image

支持后:

image

Changelog

support base64 icon on editor glyphMargin and treeview

@github-actions github-actions bot added the 🎨 feature feature required label Nov 24, 2022
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 57.45% // Head: 57.43% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (cdf63d1) compared to base (1df4974).
Patch coverage: 30.76% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2010      +/-   ##
==========================================
- Coverage   57.45%   57.43%   -0.03%     
==========================================
  Files        1289     1289              
  Lines       80677    80716      +39     
  Branches    16877    16889      +12     
==========================================
+ Hits        46351    46356       +5     
- Misses      31206    31237      +31     
- Partials     3120     3123       +3     
Flag Coverage Δ
jsdom 52.19% <30.76%> (-0.02%) ⬇️
node 15.86% <9.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re-browser/src/keyboard/keyboard-layout-service.ts 90.52% <ø> (ø)
...ion/src/browser/vscode/api/main.thread.treeview.ts 47.00% <0.00%> (-1.63%) ⬇️
...tension/src/hosted/api/vscode/ext.host.treeview.ts 57.14% <0.00%> (-0.31%) ⬇️
...ext/src/browser/contribution/terminal.lifecycle.ts 0.00% <0.00%> (ø)
...s/terminal-next/src/browser/terminal.controller.ts 31.85% <0.00%> (-0.68%) ⬇️
...ages/terminal-next/src/browser/terminal.restore.ts 0.00% <0.00%> (ø)
packages/terminal-next/src/common/controller.ts 100.00% <ø> (ø)
packages/theme/src/common/theme.service.ts 67.94% <ø> (ø)
packages/search/src/browser/search.service.ts 40.90% <31.25%> (-0.26%) ⬇️
...browser/src/menu/next/renderer/ctxmenu/electron.ts 21.15% <50.00%> (+0.76%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 1a8bb50 into main Nov 24, 2022
@erha19 erha19 deleted the fix/support-base64-icon branch November 24, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants