Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use bash resolve shellpath #2021

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Nov 28, 2022

Types

  • 🐛 Bug Fixes

Background or solution

Changelog

  • use bash resolve shell path by default

@github-actions github-actions bot added the 🐞 bug Something isn't working label Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 57.43% // Head: 57.46% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (e52d248) compared to base (1a8bb50).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2021      +/-   ##
==========================================
+ Coverage   57.43%   57.46%   +0.02%     
==========================================
  Files        1291     1292       +1     
  Lines       80630    80860     +230     
  Branches    16831    16884      +53     
==========================================
+ Hits        46313    46466     +153     
- Misses      31193    31267      +74     
- Partials     3124     3127       +3     
Flag Coverage Δ
jsdom 52.32% <ø> (+0.04%) ⬆️
node 15.74% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-node/src/bootstrap/shell-path.ts 81.81% <ø> (-0.33%) ⬇️
packages/extension/src/browser/extension.ts 54.20% <0.00%> (-2.24%) ⬇️
...ges/extension/src/node/extension.service.client.ts 65.78% <0.00%> (-1.34%) ⬇️
packages/markdown/src/common/index.ts 100.00% <0.00%> (ø)
packages/components/src/utils/marked.ts 81.81% <0.00%> (ø)
packages/extension/src/common/vscode/index.ts 100.00% <0.00%> (ø)
packages/extension/src/common/vscode/extension.ts 52.00% <0.00%> (ø)
packages/markdown/src/browser/markdown.service.ts 73.07% <0.00%> (ø)
...s/extension/src/browser/vscode/builtin-commands.ts 100.00% <0.00%> (ø)
.../extension/src/browser/vscode/contributes/index.ts 100.00% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit df33204 into main Nov 29, 2022
@erha19 erha19 deleted the fix/use-bash-resolve-shell-path branch November 29, 2022 09:11
yantze added a commit that referenced this pull request Feb 28, 2023
yantze added a commit that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants