Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support onSaveCodeActions with ESLint extension #2023

Merged
merged 4 commits into from
Nov 29, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Nov 28, 2022

Types

  • 🐛 Bug Fixes

Background or solution

close #2022

Changelog

support onSaveCodeActions with ESLint extension

@erha19 erha19 changed the title fix: support onSaveCodeActions with ESLint extension WIP: fix: support onSaveCodeActions with ESLint extension Nov 28, 2022
@github-actions github-actions bot added the 🐞 bug Something isn't working label Nov 28, 2022
@erha19 erha19 changed the title WIP: fix: support onSaveCodeActions with ESLint extension fix: support onSaveCodeActions with ESLint extension Nov 28, 2022
@erha19
Copy link
Member Author

erha19 commented Nov 28, 2022

排查到是字段 source.sourceFixAll 已不再支持,支持了自动保存格式化功能
Kapture 2022-11-28 at 23 59 15

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 57.43% // Head: 57.43% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (52b7c78) compared to base (1a8bb50).
Patch coverage: 46.78% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2023      +/-   ##
==========================================
- Coverage   57.43%   57.43%   -0.01%     
==========================================
  Files        1291     1292       +1     
  Lines       80630    80886     +256     
  Branches    16831    16893      +62     
==========================================
+ Hits        46313    46460     +147     
- Misses      31193    31294     +101     
- Partials     3124     3132       +8     
Flag Coverage Δ
jsdom 52.30% <46.78%> (+0.02%) ⬆️
node 15.74% <3.50%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/extension/src/common/vscode/languages.ts 86.36% <ø> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
...s/editor/src/browser/doc-model/saveParticipants.ts 23.86% <10.90%> (-6.44%) ⬇️
...tension/src/hosted/api/vscode/ext.host.language.ts 45.45% <57.69%> (-0.08%) ⬇️
...sion/src/hosted/api/vscode/language/code-action.ts 65.00% <75.00%> (-1.67%) ⬇️
...ion/src/browser/vscode/api/main.thread.language.ts 57.27% <100.00%> (ø)
packages/extension/src/common/vscode/ext-types.ts 50.49% <100.00%> (ø)
packages/utils/src/buffer.ts 30.81% <0.00%> (-2.33%) ⬇️
packages/extension/src/browser/extension.ts 54.20% <0.00%> (-2.24%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 7633d99 into main Nov 29, 2022
@erha19 erha19 deleted the fix/eslint-auto-formate-rules branch November 29, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ESLint 2.2.6 插件不支持保存自动格式化能力
2 participants