Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: progress codeAction when codeActionOnSave existed #2027

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Nov 30, 2022

Types

  • 🐛 Bug Fixes

Background or solution

仅在配置了 editor.codeActionsOnSave 情况下启用 Progress 逻辑

Changelog

just progress codeAction when codeActionOnSave existed

@github-actions github-actions bot added the 🐞 bug Something isn't working label Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 57.44% // Head: 57.44% // No change to project coverage 👍

Coverage data is based on head (35585fb) compared to base (392a82b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2027   +/-   ##
=======================================
  Coverage   57.44%   57.44%           
=======================================
  Files        1292     1292           
  Lines       80886    80886           
  Branches    16892    16892           
=======================================
  Hits        46468    46468           
  Misses      31287    31287           
  Partials     3131     3131           
Flag Coverage Δ
jsdom 52.31% <0.00%> (ø)
node 15.74% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/editor/src/browser/doc-model/saveParticipants.ts 23.86% <0.00%> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 2d40ae8 into main Nov 30, 2022
@erha19 erha19 deleted the fix/eslint/progress-when-code-action-existed branch November 30, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants