Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize default extension icon #2030

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Conversation

bk1012
Copy link
Member

@bk1012 bk1012 commented Nov 30, 2022

Types

  • 🧹 Chores

Background or solution

插件默认 logo 为一张图片,改为由内置的 iconfont 实现

Changelog

Before:
image

After:
image

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 57.44% // Head: 57.44% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f0001a7) compared to base (392a82b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2030   +/-   ##
=======================================
  Coverage   57.44%   57.44%           
=======================================
  Files        1292     1292           
  Lines       80886    80885    -1     
  Branches    16892    16892           
=======================================
  Hits        46468    46468           
+ Misses      31287    31286    -1     
  Partials     3131     3131           
Flag Coverage Δ
jsdom 52.31% <ø> (+<0.01%) ⬆️
node 15.74% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/extension-manager/src/browser/const.ts 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit a2f04f0 into main Nov 30, 2022
@erha19 erha19 deleted the feat/set-extension-default-icon branch November 30, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants