Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove errors from clipboard service #2054

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Dec 6, 2022

Types

  • 🧹 Chores

Background or solution

before:

image

Changelog

remove errors from clipboard service

@erha19
Copy link
Member Author

erha19 commented Dec 6, 2022

同时通过内置 AppConfigScopedBrowserStorageService 中,后续支持直接通过 @Autowire(ScopedBrowserStorageService) 方式使用该服务

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 57.66% // Head: 57.66% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9e6c472) compared to base (ff7bcea).
Patch coverage: 90.47% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2054   +/-   ##
=======================================
  Coverage   57.66%   57.66%           
=======================================
  Files        1291     1291           
  Lines       81079    81072    -7     
  Branches    16898    16898           
=======================================
- Hits        46752    46750    -2     
+ Misses      31201    31196    -5     
  Partials     3126     3126           
Flag Coverage Δ
jsdom 52.45% <90.47%> (+<0.01%) ⬆️
node 15.80% <19.04%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/terminal-next/src/browser/terminal.restore.ts 0.00% <0.00%> (ø)
...ges/core-browser/src/services/clipboard.service.ts 64.81% <94.11%> (-1.29%) ⬇️
...kages/core-browser/src/services/storage-service.ts 75.90% <100.00%> (+0.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit ed89da2 into main Dec 7, 2022
@erha19 erha19 deleted the chore/remove-file-tree-contextmunu-error branch December 7, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants