Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: electron cannot work #2060

Merged
merged 7 commits into from
Dec 7, 2022
Merged

fix: electron cannot work #2060

merged 7 commits into from
Dec 7, 2022

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented Dec 7, 2022

Types

  • 🧹 Chores

Background or solution

Changelog

erha19
erha19 previously approved these changes Dec 7, 2022
@bytemain bytemain changed the title chore: update script fix: electron cannot work Dec 7, 2022
@github-actions github-actions bot added the 🐞 bug Something isn't working label Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 57.67% // Head: 57.66% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (1031b31) compared to base (9907c4e).
Patch coverage: 59.09% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2060      +/-   ##
==========================================
- Coverage   57.67%   57.66%   -0.01%     
==========================================
  Files        1291     1291              
  Lines       81072    81084      +12     
  Branches    16896    16902       +6     
==========================================
+ Hits        46756    46759       +3     
- Misses      31193    31201       +8     
- Partials     3123     3124       +1     
Flag Coverage Δ
jsdom 52.45% <59.09%> (-0.01%) ⬇️
node 15.81% <59.09%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/utils/src/process.ts 59.09% <47.05%> (+9.09%) ⬆️
packages/utils/src/os.ts 80.00% <100.00%> (+3.07%) ⬆️
packages/utils/src/buffer.ts 29.65% <0.00%> (-4.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

erha19
erha19 previously approved these changes Dec 7, 2022
tools/electron/package.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants