Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension): windows get globalStorageUri error #2068

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented Dec 7, 2022

Types

  • 🐛 Bug Fixes

Background or solution

Windows 上调用 ExtensionContext.globalStoragePath 的地址有误:
CleanShot 2022-12-07 at 18 23 18@2x

原理可见:

CleanShot 2022-12-07 at 18 22 27@2x

又是一例 Uri.parse 和 Uri.file 的混用错误,会导致插件获取的 globalStoragePath 错误。

Changelog

Fix invoke ExtensionContext.globalStoragePath error in Windows

@bytemain bytemain requested a review from Aaaaash December 7, 2022 10:24
@github-actions github-actions bot added the 🐞 bug Something isn't working label Dec 7, 2022
@bytemain bytemain changed the title fix(ext): windows get globalStorageUri error fix(ext-host): windows get globalStorageUri error Dec 7, 2022
@bytemain bytemain changed the title fix(ext-host): windows get globalStorageUri error fix(extension): windows get globalStorageUri error Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 57.66% // Head: 57.66% // No change to project coverage 👍

Coverage data is based on head (1924880) compared to base (ed89da2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2068   +/-   ##
=======================================
  Coverage   57.66%   57.66%           
=======================================
  Files        1291     1291           
  Lines       81077    81077           
  Branches    16902    16902           
=======================================
  Hits        46756    46756           
  Misses      31197    31197           
  Partials     3124     3124           
Flag Coverage Δ
jsdom 52.46% <ø> (ø)
node 15.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/extension-storage/src/browser/storage.ts 93.13% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants