Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support submenus on editor/title #2088

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Dec 15, 2022

Types

  • 🎉 New Features
  • 🐛 Bug Fixes

Background or solution

fixed #2067.

在编辑器顶部 ... 菜单支持插件 submenus 注册及展示,效果如下:

Web:
image

Electron:

image

Changelog

support submenus on editor/title

@github-actions github-actions bot added 🎨 feature feature required 🐞 bug Something isn't working labels Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 57.75% // Head: 57.75% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (dbc6f4a) compared to base (80d6723).
Patch coverage: 40.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2088   +/-   ##
=======================================
  Coverage   57.75%   57.75%           
=======================================
  Files        1291     1291           
  Lines       81101    81098    -3     
  Branches    16925    16924    -1     
=======================================
+ Hits        46839    46840    +1     
+ Misses      31144    31141    -3     
+ Partials     3118     3117    -1     
Flag Coverage Δ
jsdom 52.55% <40.00%> (+<0.01%) ⬆️
node 16.91% <40.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/core-browser/src/bootstrap/inner-providers.ts 100.00% <ø> (ø)
packages/editor/src/browser/types.ts 100.00% <ø> (ø)
...s/extension/src/browser/vscode/contributes/menu.ts 51.77% <ø> (ø)
packages/editor/src/browser/menu/editor.menu.ts 31.81% <40.00%> (+3.81%) ⬆️
packages/monaco/src/browser/schema-registry.ts 71.11% <0.00%> (+2.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 88c80a4 into main Dec 16, 2022
@erha19 erha19 deleted the feat/support-extension-submenu-contribution branch December 16, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 支持 submenu 菜单贡献点
2 participants