Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve preference panel #2089

Merged
merged 33 commits into from
Dec 23, 2022
Merged

feat: improve preference panel #2089

merged 33 commits into from
Dec 23, 2022

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented Dec 15, 2022

Types

  • 🎉 New Features

Background or solution

original: #1750

CleanShot.2022-12-22.at.16.43.34.mp4

Changelog

Improve Preference Panel

@github-actions github-actions bot added the 🎨 feature feature required label Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 57.73% // Head: 57.71% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (a4e330f) compared to base (21fe449).
Patch coverage: 60.31% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2089      +/-   ##
==========================================
- Coverage   57.73%   57.71%   -0.02%     
==========================================
  Files        1291     1294       +3     
  Lines       81154    81403     +249     
  Branches    16947    16986      +39     
==========================================
+ Hits        46856    46984     +128     
- Misses      31179    31288     +109     
- Partials     3119     3131      +12     
Flag Coverage Δ
jsdom 52.53% <60.31%> (-0.01%) ⬇️
node 16.85% <1.58%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/src/recycle-tree/basic/tree-node.define.ts 8.69% <0.00%> (+0.36%) ⬆️
.../components/src/recycle-tree/basic/tree-service.ts 5.88% <0.00%> (-0.85%) ⬇️
...ackages/components/src/recycle-tree/basic/types.ts 100.00% <ø> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
packages/preferences/src/common/types.ts 100.00% <ø> (ø)
...ore-browser/src/react-hooks/useThrottleFn/index.ts 25.00% <25.00%> (ø)
...on/src/browser/vscode/contributes/configuration.ts 65.21% <60.00%> (-2.53%) ⬇️
...erences/src/browser/preference-settings.service.ts 76.85% <71.29%> (+0.78%) ⬆️
packages/extension/src/browser/extension.ts 55.04% <75.00%> (+0.84%) ⬆️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bytemain bytemain marked this pull request as ready for review December 22, 2022 08:48
Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 0f7204f into main Dec 23, 2022
@erha19 erha19 deleted the feat/update-preference branch December 23, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants