Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the tree node child maybe undefined #2096

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Dec 19, 2022

Types

  • 🐛 Bug Fixes

Background or solution

image

Changelog

the tree node child maybe undefined

@github-actions github-actions bot added the 🐞 bug Something isn't working label Dec 19, 2022
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 57.75% // Head: 57.76% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (9f48d43) compared to base (006d593).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2096      +/-   ##
==========================================
+ Coverage   57.75%   57.76%   +0.01%     
==========================================
  Files        1291     1291              
  Lines       81118    81085      -33     
  Branches    16931    16930       -1     
==========================================
- Hits        46848    46840       -8     
+ Misses      31152    31127      -25     
  Partials     3118     3118              
Flag Coverage Δ
jsdom 52.55% <66.66%> (+0.01%) ⬆️
node 16.91% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/components/src/recycle-tree/types/tree-node.ts 100.00% <ø> (ø)
...r/components/scm-resource-tree/scm-tree.service.ts 18.03% <ø> (+3.36%) ⬆️
...onents/scm-resource-tree/scm-tree-model.service.ts 11.69% <50.00%> (+0.35%) ⬆️
...kages/components/src/recycle-tree/tree/TreeNode.ts 68.67% <75.00%> (ø)
packages/monaco/src/browser/schema-registry.ts 68.88% <0.00%> (-2.23%) ⬇️
packages/utils/src/buffer.ts 31.97% <0.00%> (-1.75%) ⬇️
...erences/src/browser/preference-settings.service.ts 75.46% <0.00%> (-0.62%) ⬇️
...kages/theme/src/browser/workbench.theme.service.ts 71.38% <0.00%> (-0.58%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

bytemain
bytemain previously approved these changes Dec 19, 2022
Copy link
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 88386c8 into main Dec 19, 2022
@erha19 erha19 deleted the fix/tree/dispose-error branch December 19, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants