Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update keybindings when keymap view rendered #2104

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Dec 21, 2022

Types

  • 🚀 Performance Improvements

Background or solution

Changelog

  • fix: update keybindings when keymap view rendered

@github-actions github-actions bot added the 🐞 bug Something isn't working label Dec 21, 2022
@erha19 erha19 added this to the 2.22 milestone Dec 21, 2022
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 57.74% // Head: 57.72% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (cd4e104) compared to base (3d9a8e9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2104      +/-   ##
==========================================
- Coverage   57.74%   57.72%   -0.03%     
==========================================
  Files        1291     1291              
  Lines       81117    81154      +37     
  Branches    16939    16947       +8     
==========================================
+ Hits        46845    46849       +4     
- Misses      31153    31184      +31     
- Partials     3119     3121       +2     
Flag Coverage Δ
jsdom 52.52% <100.00%> (-0.02%) ⬇️
node 16.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/keymaps/src/common/keymaps.ts 100.00% <ø> (ø)
packages/keymaps/src/browser/keymaps.service.ts 60.32% <100.00%> (-0.11%) ⬇️
...tor/src/browser/doc-model/editor-document-model.ts 56.07% <0.00%> (-5.68%) ⬇️
packages/output/src/browser/output.service.ts 67.14% <0.00%> (-1.98%) ⬇️
...erences/src/browser/preference-settings.service.ts 75.46% <0.00%> (-0.62%) ⬇️
...kages/theme/src/browser/workbench.theme.service.ts 71.38% <0.00%> (-0.58%) ⬇️
packages/utils/src/buffer.ts 31.97% <0.00%> (+2.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Aaaaash Aaaaash merged commit 21fe449 into main Dec 22, 2022
@Aaaaash Aaaaash deleted the fix/update-keybindings-when-keymap-view-rendered branch December 22, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants