Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove DeprecatedRecycleTree component #2111

Merged
merged 5 commits into from
Dec 28, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Dec 23, 2022

Types

  • 🪚 Refactors

Background or solution

重新实现了 CoreCommentsContribution 贡献点中针对 registerPanelTreeNodeHandler 的实现,由于字段冲突有相应 BK,即在处理节点时,原有的 node.name = () => <div></div> 的方式不再支持,需要修改为 node.label = React.ReactNode | string 的写法。伪代码如下:

@Domain(CoreCommentsContribution)
class AddonContribution implements CoreCommentsContribution {
  registerCommentsFeature(registry: ICommentsFeatureRegistry) {
    registry.registerPanelTreeNodeHandler((nodes) => {
      // 在一次节点更新阶段会多次调用,非一次性返回所有节点
      return nodes.map((node) => {
        node.label = 'label';
        node.description = 'This is a description.';
        node.onSelect = (node) => {
          console.log(node);
        };
        return node;
      });
    });
  }
}

close #592

Changelog

remove DeprecatedRecycleTree component

@github-actions github-actions bot added the ⚙️ refactor Refactor code label Dec 23, 2022
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Base: 57.72% // Head: 57.73% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (6afe35b) compared to base (d93b6d3).
Patch coverage: 45.45% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2111      +/-   ##
==========================================
+ Coverage   57.72%   57.73%   +0.01%     
==========================================
  Files        1299     1291       -8     
  Lines       81607    81536      -71     
  Branches    17009    16978      -31     
==========================================
- Hits        47106    47074      -32     
+ Misses      31368    31341      -27     
+ Partials     3133     3121      -12     
Flag Coverage Δ
jsdom 52.55% <45.45%> (+<0.01%) ⬆️
node 16.76% <3.03%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/comments/src/common/index.ts 100.00% <ø> (ø)
packages/core-browser/src/components/index.ts 100.00% <ø> (ø)
packages/main-layout/src/browser/layout.service.ts 62.04% <0.00%> (ø)
...ges/comments/src/browser/tree/tree-node.defined.ts 47.50% <34.09%> (-8.75%) ⬇️
...kages/components/src/recycle-tree/tree/TreeNode.ts 68.64% <50.00%> (-0.25%) ⬇️
.../comments/src/browser/comments-feature.registry.ts 71.42% <100.00%> (+4.76%) ⬆️
packages/comments/src/browser/comments.service.ts 50.78% <100.00%> (+1.19%) ⬆️
packages/core-browser/src/index.ts 100.00% <100.00%> (ø)
packages/search/src/common/content-search.ts 67.08% <100.00%> (-0.42%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 changed the title WIP: refactor: remove DeprecatedRecycleTree component refactor: remove DeprecatedRecycleTree component Dec 23, 2022
@erha19
Copy link
Member Author

erha19 commented Dec 23, 2022

重新实现了 CoreCommentsContribution 贡献点中针对 registerPanelTreeNodeHandler 的实现,由于字段冲突有相应 BK,即在处理节点时,原有的 node.name = () => <div></div> 的方式不再支持,需要修改为 node.label = React.ReactNode | string 的写法。伪代码如下:

@Domain(CoreCommentsContribution)
class AddonContribution implements CoreCommentsContribution {
  registerCommentsFeature(registry: ICommentsFeatureRegistry) {
    registry.registerPanelTreeNodeHandler((nodes) => {
      // 在一次节点更新阶段会多次调用,非一次性返回所有节点
      return nodes.map((node) => {
        node.label = 'label';
        node.description = 'This is a description.';
        node.onSelect = (node) => {
          console.log(node);
        };
        return node;
      });
    });
  }
}

@hacke2 @Ricbet 看一下,集成侧需要改一下,改造后相应的语言提示将会更加完整,不再是以前的 any 类型盲写。

@Ricbet
Copy link
Member

Ricbet commented Dec 26, 2022

看起来删了很多模块代码,新的实现在哪

@erha19 erha19 merged commit 7d2bd61 into main Dec 28, 2022
@erha19 erha19 deleted the refactor/remove-deprecated-recycle-tree branch December 28, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated RecycleTree on @opensumi/ide-core-browser
2 participants