-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove DeprecatedRecycleTree component #2111
Conversation
Codecov ReportBase: 57.72% // Head: 57.73% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2111 +/- ##
==========================================
+ Coverage 57.72% 57.73% +0.01%
==========================================
Files 1299 1291 -8
Lines 81607 81536 -71
Branches 17009 16978 -31
==========================================
- Hits 47106 47074 -32
+ Misses 31368 31341 -27
+ Partials 3133 3121 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
重新实现了 @Domain(CoreCommentsContribution)
class AddonContribution implements CoreCommentsContribution {
registerCommentsFeature(registry: ICommentsFeatureRegistry) {
registry.registerPanelTreeNodeHandler((nodes) => {
// 在一次节点更新阶段会多次调用,非一次性返回所有节点
return nodes.map((node) => {
node.label = 'label';
node.description = 'This is a description.';
node.onSelect = (node) => {
console.log(node);
};
return node;
});
});
}
} @hacke2 @Ricbet 看一下,集成侧需要改一下,改造后相应的语言提示将会更加完整,不再是以前的 |
看起来删了很多模块代码,新的实现在哪 |
Types
Background or solution
重新实现了
CoreCommentsContribution
贡献点中针对registerPanelTreeNodeHandler
的实现,由于字段冲突有相应 BK,即在处理节点时,原有的node.name = () => <div></div>
的方式不再支持,需要修改为node.label = React.ReactNode | string
的写法。伪代码如下:close #592
Changelog
remove DeprecatedRecycleTree component