Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search rules display logic #2124

Merged
merged 3 commits into from
Dec 28, 2022
Merged

fix: search rules display logic #2124

merged 3 commits into from
Dec 28, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Dec 26, 2022

Types

  • 🐛 Bug Fixes

Background or solution

ref #2115.

  • 添加 E2E 测试

Changelog

fix search rules display logic

@github-actions github-actions bot added the 🐞 bug Something isn't working label Dec 26, 2022
@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Base: 57.76% // Head: 57.76% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (2f09b5e) compared to base (4703237).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2124   +/-   ##
=======================================
  Coverage   57.76%   57.76%           
=======================================
  Files        1299     1291    -8     
  Lines       81630    81585   -45     
  Branches    17017    16993   -24     
=======================================
- Hits        47152    47128   -24     
+ Misses      31346    31334   -12     
+ Partials     3132     3123    -9     
Flag Coverage Δ
jsdom 52.59% <100.00%> (-0.01%) ⬇️
node 16.76% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/search/src/browser/search.service.ts 49.76% <100.00%> (ø)
...ges/comments/src/browser/tree/tree-node.defined.ts 47.50% <0.00%> (-8.75%) ⬇️
packages/monaco/src/browser/schema-registry.ts 68.88% <0.00%> (-2.23%) ⬇️
...sion/src/hosted/api/vscode/ext.host.api.webview.ts 69.89% <0.00%> (-0.61%) ⬇️
...s/terminal-next/src/browser/terminal.controller.ts 33.07% <0.00%> (-0.61%) ⬇️
packages/search/src/common/content-search.ts 67.08% <0.00%> (-0.42%) ⬇️
...kages/components/src/recycle-tree/tree/TreeNode.ts 68.64% <0.00%> (-0.25%) ⬇️
...owser/monaco-contrib/tokenizer/textmate.service.ts 18.71% <0.00%> (-0.08%) ⬇️
packages/comments/src/common/index.ts 100.00% <0.00%> (ø)
packages/core-browser/src/components/index.ts 100.00% <0.00%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 changed the title WIP: fix: search rules display logic fix: search rules display logic Dec 27, 2022
@erha19
Copy link
Member Author

erha19 commented Dec 27, 2022

@Aaaaash 搞完了

@erha19 erha19 requested a review from Aaaaash December 27, 2022 02:27
@erha19 erha19 mentioned this pull request Dec 28, 2022
1 task
@erha19 erha19 merged commit 6052dba into main Dec 28, 2022
@erha19 erha19 deleted the fix/search/ui-state-update branch December 28, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants