Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unnecessary re-tokenizer #2125

Merged
merged 1 commit into from
Dec 27, 2022
Merged

fix: unnecessary re-tokenizer #2125

merged 1 commit into from
Dec 27, 2022

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Dec 27, 2022

Types

  • 🐛 Bug Fixes

Background or solution

重复调用 setTheme 会导致编辑器重复触发 tokenize

Changelog

  • fix unnecessary re-tokenizer

@github-actions github-actions bot added the 🐞 bug Something isn't working label Dec 27, 2022
@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Base: 57.76% // Head: 57.76% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (98b2479) compared to base (4703237).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2125      +/-   ##
==========================================
- Coverage   57.76%   57.76%   -0.01%     
==========================================
  Files        1299     1299              
  Lines       81630    81640      +10     
  Branches    17017    17019       +2     
==========================================
+ Hits        47152    47157       +5     
- Misses      31346    31349       +3     
- Partials     3132     3134       +2     
Flag Coverage Δ
jsdom 52.59% <0.00%> (-0.01%) ⬇️
node 16.82% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...owser/monaco-contrib/tokenizer/textmate.service.ts 18.71% <0.00%> (-0.08%) ⬇️
...sion/src/hosted/api/vscode/ext.host.api.webview.ts 69.89% <0.00%> (-0.61%) ⬇️
...file-service/src/node/disk-file-system.provider.ts 78.71% <0.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 35f7467 into main Dec 27, 2022
@erha19 erha19 deleted the fix/unnecessary-re-tokenizer branch December 27, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants