Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create diff and merge editor as needed #2135

Merged
merged 6 commits into from
Jan 12, 2023
Merged

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Dec 28, 2022

Types

  • 🚀 Performance Improvements

Background or solution

Changelog

  • create diff and merge editor as needed

@github-actions github-actions bot added the 🐞 bug Something isn't working label Dec 28, 2022
Ricbet
Ricbet previously approved these changes Dec 28, 2022
@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Base: 57.80% // Head: 57.80% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a58ab39) compared to base (4b0e852).
Patch coverage: 47.34% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2135   +/-   ##
=======================================
  Coverage   57.80%   57.80%           
=======================================
  Files        1316     1316           
  Lines       83020    83071   +51     
  Branches    17273    17287   +14     
=======================================
+ Hits        47987    48021   +34     
- Misses      31838    31854   +16     
- Partials     3195     3196    +1     
Flag Coverage Δ
jsdom 52.76% <47.34%> (+<0.01%) ⬆️
node 16.48% <3.72%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...electron-basic/src/browser/welcome/contribution.ts 78.26% <ø> (ø)
...xtension/src/browser/vscode/api/main.thread.doc.ts 61.07% <ø> (ø)
packages/markdown/src/browser/contribution.ts 0.00% <0.00%> (ø)
packages/webview/src/browser/webview.service.ts 38.96% <ø> (ø)
...ges/editor/src/browser/workbench-editor.service.ts 59.35% <41.40%> (-0.02%) ⬇️
...nsion/src/browser/vscode/api/main.thread.editor.ts 44.41% <64.70%> (+0.53%) ⬆️
packages/editor/src/browser/diff/index.ts 94.28% <100.00%> (ø)
packages/editor/src/browser/history/index.ts 67.27% <100.00%> (+0.60%) ⬆️
packages/editor/src/common/editor.ts 100.00% <100.00%> (ø)
...on/src/browser/sumi-browser/contribution/editor.ts 28.57% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 added this to the 2.22 milestone Jan 10, 2023
@Aaaaash Aaaaash force-pushed the fix/diff-merge-editor-create branch from 4560347 to 3b893dd Compare January 11, 2023 03:09
@erha19
Copy link
Member

erha19 commented Jan 11, 2023

@Aaaaash 这里测试挂了

erha19
erha19 previously approved these changes Jan 12, 2023
@erha19 erha19 merged commit 08d2d12 into main Jan 12, 2023
@erha19 erha19 deleted the fix/diff-merge-editor-create branch January 12, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants