Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support search and replace value by regexp #2138

Merged
merged 2 commits into from
Dec 30, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Dec 28, 2022

Types

  • 🎉 New Features
  • 🐛 Bug Fixes

Background or solution

fixed #1962.

同时修复通过编辑器选中文本进行搜索的交互问题。

Changelog

support search and replace value by regexp

@github-actions github-actions bot added 🎨 feature feature required 🐞 bug Something isn't working labels Dec 28, 2022
@erha19
Copy link
Member Author

erha19 commented Dec 28, 2022

正则匹配替换效果:

Kapture.2022-12-28.at.17.04.05.mp4

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Base: 57.78% // Head: 57.78% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (68bd4c6) compared to base (7d0f2e9).
Patch coverage: 78.94% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2138   +/-   ##
=======================================
  Coverage   57.78%   57.78%           
=======================================
  Files        1313     1313           
  Lines       82995    83001    +6     
  Branches    17256    17256           
=======================================
+ Hits        47958    47964    +6     
  Misses      31846    31846           
  Partials     3191     3191           
Flag Coverage Δ
jsdom 52.72% <78.94%> (+<0.01%) ⬆️
node 16.52% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/search/src/browser/tree/search-tree.service.ts 49.36% <ø> (ø)
packages/search/src/common/content-search.ts 67.08% <ø> (ø)
packages/search/src/browser/search.service.ts 49.88% <25.00%> (+0.34%) ⬆️
packages/search/src/browser/replace.ts 75.60% <93.33%> (+4.64%) ⬆️
packages/utils/src/buffer.ts 31.97% <0.00%> (-1.75%) ⬇️
...ges/editor/src/browser/workbench-editor.service.ts 59.37% <0.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

.kaitian Outdated Show resolved Hide resolved
@erha19 erha19 force-pushed the feat/support-search-and-replace-value-by-regexp branch from 92abcd6 to 68bd4c6 Compare December 29, 2022 07:14
@erha19 erha19 merged commit 06bad8e into main Dec 30, 2022
@erha19 erha19 deleted the feat/support-search-and-replace-value-by-regexp branch December 30, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 搜索替换需支持正则捕获
2 participants