Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not exclude .gitignore #2142

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Dec 30, 2022

Types

  • 🐛 Bug Fixes

Background or solution

默认添加的这个 *.git* 不仅排除 git 目录,也会排除所有包含 .git 的文件,实际上只需要 *.git/ 即可

Changelog

  • do not exclude .gitignore

@github-actions github-actions bot added the 🐞 bug Something isn't working label Dec 30, 2022
@Aaaaash Aaaaash force-pushed the fix/do-not-exclude-gitignore-by-default branch from 51daf9a to e18f090 Compare December 30, 2022 03:18
@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Base: 57.78% // Head: 57.78% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (e18f090) compared to base (7d0f2e9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2142   +/-   ##
=======================================
  Coverage   57.78%   57.78%           
=======================================
  Files        1313     1313           
  Lines       82995    82996    +1     
  Branches    17256    17257    +1     
=======================================
+ Hits        47958    47961    +3     
+ Misses      31846    31844    -2     
  Partials     3191     3191           
Flag Coverage Δ
jsdom 52.72% <100.00%> (+<0.01%) ⬆️
node 16.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-browser/src/core-preferences.ts 92.30% <100.00%> (ø)
...es/editor/src/browser/editor-collection.service.ts 66.66% <0.00%> (-0.27%) ⬇️
...ges/editor/src/browser/workbench-editor.service.ts 59.37% <0.00%> (+0.03%) ⬆️
...erences/src/browser/preference-settings.service.ts 76.85% <0.00%> (+0.43%) ⬆️
...kages/theme/src/browser/workbench.theme.service.ts 71.96% <0.00%> (+0.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 603c537 into main Dec 30, 2022
@erha19 erha19 deleted the fix/do-not-exclude-gitignore-by-default branch December 30, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants