Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve regexp search ux #2185

Merged
merged 1 commit into from
Jan 10, 2023
Merged

fix: improve regexp search ux #2185

merged 1 commit into from
Jan 10, 2023

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jan 10, 2023

Types

  • 🐛 Bug Fixes

Background or solution

fixed #2184.

Changelog

improve regexp search ux

@erha19 erha19 requested a review from bytemain January 10, 2023 10:34
@github-actions github-actions bot added the 🐞 bug Something isn't working label Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 57.77% // Head: 57.78% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7bd4ccb) compared to base (144720e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2185   +/-   ##
=======================================
  Coverage   57.77%   57.78%           
=======================================
  Files        1315     1315           
  Lines       83050    83050           
  Branches    17291    17291           
=======================================
+ Hits        47986    47994    +8     
+ Misses      31867    31860    -7     
+ Partials     3197     3196    -1     
Flag Coverage Δ
jsdom 52.74% <ø> (+<0.01%) ⬆️
node 16.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
packages/search/src/browser/replace.ts 75.60% <ø> (ø)
...erences/src/browser/preference-settings.service.ts 76.85% <0.00%> (+0.43%) ⬆️
...kages/theme/src/browser/workbench.theme.service.ts 71.96% <0.00%> (+0.57%) ⬆️
packages/monaco/src/browser/schema-registry.ts 71.11% <0.00%> (+2.22%) ⬆️
packages/utils/src/buffer.ts 31.97% <0.00%> (+2.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Search result will be empty when search text changed
2 participants