Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: remove some useless tree style #2186

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jan 10, 2023

Types

  • 💄 Style Changes

Background or solution

移除了不同视图下的冗余样式,修复 Marker / OpenedEditor 等面板在 Light+ 主题下异常展示问题
image

fixed #2179

Changelog

remove some useless tree style

@erha19 erha19 requested a review from bytemain January 10, 2023 13:11
@github-actions github-actions bot added 🐞 bug Something isn't working 💄 style change labels Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 57.77% // Head: 57.79% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (3f9e738) compared to base (144720e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2186      +/-   ##
==========================================
+ Coverage   57.77%   57.79%   +0.01%     
==========================================
  Files        1315     1315              
  Lines       83050    83038      -12     
  Branches    17291    17291              
==========================================
+ Hits        47986    47990       +4     
+ Misses      31867    31851      -16     
  Partials     3197     3197              
Flag Coverage Δ
jsdom 52.74% <0.00%> (+0.01%) ⬆️
node 16.50% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...line/src/browser/services/outline-model.service.ts 55.41% <ø> (-0.29%) ⬇️
...onents/scm-resource-tree/scm-tree-model.service.ts 11.76% <0.00%> (+0.17%) ⬆️
...ser/components/scm-resource-tree/scm-tree-model.ts 42.85% <ø> (+6.01%) ⬆️
packages/utils/src/buffer.ts 33.72% <0.00%> (+4.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 3d6634f into main Jan 11, 2023
@erha19 erha19 deleted the style/improve-problem-tree-node-style branch January 11, 2023 01:50
bytemain pushed a commit that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 💄 style change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 问题面板选中后背景色太深看不清文字
2 participants