Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support electron titlebar string template #2194

Merged
merged 9 commits into from
Jan 22, 2023

Conversation

yantze
Copy link
Member

@yantze yantze commented Jan 12, 2023

Types

  • 🎉 New Features

Background or solution

支持 setting.json 设置 window.title 标题模板,比如 ${dirty}${activeEditorShort}${separator}${rootName} 或者${dirty}${activeEditorShort}${separator}${appName}

Untitled.mov

Changelog

支持通过 window.title 控制窗口标题

@github-actions github-actions bot added the 🎨 feature feature required label Jan 12, 2023
@yantze yantze changed the title WIP:feat: support electron titlebar string template feat: support electron titlebar string template Jan 12, 2023
@erha19 erha19 added this to the 2.23 milestone Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 57.80% // Head: 57.80% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (a9ea55d) compared to base (cf3e391).
Patch coverage: 73.68% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2194      +/-   ##
==========================================
- Coverage   57.80%   57.80%   -0.01%     
==========================================
  Files        1316     1319       +3     
  Lines       83016    83036      +20     
  Branches    17272    17275       +3     
==========================================
+ Hits        47987    47998      +11     
- Misses      31834    31842       +8     
- Partials     3195     3196       +1     
Flag Coverage Δ
jsdom 52.74% <5.26%> (-0.02%) ⬇️
node 16.64% <73.68%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-browser/src/preferences/types.ts 100.00% <ø> (ø)
packages/electron-basic/src/common/header.ts 100.00% <ø> (ø)
...lectron-basic/src/browser/header/header.service.ts 86.84% <44.44%> (-5.92%) ⬇️
...core-browser/src/preferences/preference-service.ts 74.13% <100.00%> (ø)
packages/electron-basic/src/browser/index.ts 74.28% <100.00%> (+0.49%) ⬆️
...kages/electron-basic/src/common/i18n/en-US.lang.ts 100.00% <100.00%> (ø)
packages/electron-basic/src/common/i18n/setup.ts 100.00% <100.00%> (ø)
...kages/electron-basic/src/common/i18n/zh-CN.lang.ts 100.00% <100.00%> (ø)
packages/utils/src/buffer.ts 29.65% <0.00%> (-2.33%) ⬇️
...collaboration/src/browser/collaboration.service.ts 74.39% <0.00%> (+0.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 20d502e into main Jan 22, 2023
@erha19 erha19 deleted the feat/electron-titlebar-template branch January 22, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants