Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get valid preference value from the user scope #2196

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jan 12, 2023

Types

  • 🐛 Bug Fixes

Background or solution

ref #2176.

Changelog

get valid preference value from the user scope

@github-actions github-actions bot added the 🐞 bug Something isn't working label Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 57.80% // Head: 57.80% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (b771753) compared to base (4b0e852).
Patch coverage: 88.23% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2196      +/-   ##
==========================================
- Coverage   57.80%   57.80%   -0.01%     
==========================================
  Files        1316     1316              
  Lines       83020    83019       -1     
  Branches    17273    17272       -1     
==========================================
- Hits        47987    47986       -1     
  Misses      31838    31838              
  Partials     3195     3195              
Flag Coverage Δ
jsdom 52.75% <88.23%> (-0.01%) ⬇️
node 16.49% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...core-browser/src/preferences/preference-service.ts 74.04% <88.23%> (-0.09%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit f200ec9 into main Jan 12, 2023
@erha19 erha19 deleted the fix/preference/get-valid-value branch January 12, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants