Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove some useless icons #2204

Merged
merged 6 commits into from
Feb 16, 2023

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jan 13, 2023

Types

  • 💄 Style Changes

Background or solution

After:
image

Remove some useless icons
icon list

Changelog

remove some useless or fill icons

@github-actions github-actions bot added the ⚙️ refactor Refactor code label Jan 13, 2023
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 16.84% // Head: 57.75% // Increases project coverage by +40.90% 🎉

Coverage data is based on head (adf9953) compared to base (f93e06d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2204       +/-   ##
===========================================
+ Coverage   16.84%   57.75%   +40.90%     
===========================================
  Files        1321     1321               
  Lines       83251    83251               
  Branches    17331    17331               
===========================================
+ Hits        14026    48078    +34052     
+ Misses      63248    31964    -31284     
+ Partials     5977     3209     -2768     
Flag Coverage Δ
jsdom 52.72% <100.00%> (?)
node 16.84% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/components/src/icon/iconfont/iconManager.ts 90.32% <ø> (+6.45%) ⬆️
packages/components/src/icon/iconfont/iconMap.ts 100.00% <ø> (ø)
...l-next/src/browser/terminal.environment.service.ts 81.70% <ø> (+81.70%) ⬆️
...ckages/core-browser/src/style/icon/ide-iconfont.ts 100.00% <100.00%> (ø)
packages/utils/src/path.ts 78.19% <0.00%> (+1.08%) ⬆️
packages/utils/src/errors.ts 46.05% <0.00%> (+1.31%) ⬆️
packages/utils/src/map.ts 84.33% <0.00%> (+1.35%) ⬆️
packages/core-browser/src/menu/next/menu-id.ts 100.00% <0.00%> (+1.38%) ⬆️
packages/extension/src/common/vscode/utils.ts 23.72% <0.00%> (+1.69%) ⬆️
packages/editor/src/common/editor.ts 100.00% <0.00%> (+1.85%) ⬆️
... and 813 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ricbet
Copy link
Member

Ricbet commented Feb 8, 2023

这个可以贴到 break change 里,一些上游可能有用到这些图标的

@erha19 erha19 force-pushed the refactor/remove-some-fill-or-useless-icon branch from c9d6ac9 to adf9953 Compare February 15, 2023 06:29
@erha19
Copy link
Member Author

erha19 commented Feb 15, 2023

这个可以贴到 break change 里,一些上游可能有用到这些图标的

已更新

@erha19 erha19 added this pull request to the merge queue Feb 16, 2023
Merged via the queue into main with commit 3d84700 Feb 16, 2023
@erha19 erha19 deleted the refactor/remove-some-fill-or-useless-icon branch February 16, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants