Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: collaboration initialize #2207

Merged
merged 1 commit into from
Jan 22, 2023
Merged

fix: collaboration initialize #2207

merged 1 commit into from
Jan 22, 2023

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Jan 16, 2023

Types

  • 🐛 Bug Fixes

Background or solution

由于 initialize 的时序太靠后了(在 onDidStart 里)
导致在刷新之后,监听不到首次打开的文件发出的 EditorDocumentModelCreationEvent 事件

Changelog

修复协同编辑模块的初始化时序问题

@Ricbet Ricbet self-assigned this Jan 16, 2023
@github-actions github-actions bot added the 🐞 bug Something isn't working label Jan 16, 2023
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 57.81% // Head: 57.81% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (6c3f4e4) compared to base (927717e).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2207      +/-   ##
==========================================
- Coverage   57.81%   57.81%   -0.01%     
==========================================
  Files        1316     1316              
  Lines       83070    83071       +1     
  Branches    17286    17286              
==========================================
- Hits        48027    48024       -3     
- Misses      31848    31851       +3     
- Partials     3195     3196       +1     
Flag Coverage Δ
jsdom 52.76% <50.00%> (-0.01%) ⬇️
node 16.48% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/collaboration/src/common/types.ts 100.00% <ø> (ø)
...collaboration/src/browser/collaboration.service.ts 72.12% <50.00%> (-2.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@situ2001 situ2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 7f78386 into main Jan 22, 2023
@erha19 erha19 deleted the fix/collaboration-initialize branch January 22, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants