Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: breadcrumbs support menus #2258

Merged
merged 13 commits into from
Mar 1, 2023

Conversation

wangxiaojuan
Copy link
Contributor

@wangxiaojuan wangxiaojuan commented Feb 9, 2023

Types

  • 🎉 New Features

Background or solution

image

Changelog

feat:支持面包屑菜单功能

packages/editor/src/browser/editor.contribution.ts Outdated Show resolved Hide resolved
packages/editor/src/browser/menu/breadcrumbs.menus.ts Outdated Show resolved Hide resolved
packages/editor/src/browser/menu/breadcrumbs.menus.ts Outdated Show resolved Hide resolved
packages/editor/src/browser/menu/breadcrumbs.menus.ts Outdated Show resolved Hide resolved
packages/editor/src/browser/navigation.view.tsx Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Feb 9, 2023

CLA assistant check
All committers have signed the CLA.

@bytemain
Copy link
Member

bytemain commented Feb 9, 2023

  • Reveal In File Tree

这个也很常用,可以加一个吗

@wangxiaojuan wangxiaojuan changed the title feat: bread scrumbs support menus feat: breadcrumbs support menus Feb 10, 2023
@Ricbet
Copy link
Member

Ricbet commented Feb 10, 2023

image

需要注意面包屑的最后末尾部分可能是当前文件的 symbol 信息,这里是不能右键的

@erha19
Copy link
Member

erha19 commented Feb 15, 2023

@wangxiaojuan CI 处理下

@wangxiaojuan
Copy link
Contributor Author

#2272

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Base: 57.77% // Head: 57.83% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (00cb1d1) compared to base (ea6688e).
Patch coverage: 54.54% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2258      +/-   ##
==========================================
+ Coverage   57.77%   57.83%   +0.05%     
==========================================
  Files        1322     1323       +1     
  Lines       83276    83247      -29     
  Branches    17332    17333       +1     
==========================================
+ Hits        48112    48145      +33     
+ Misses      31956    31900      -56     
+ Partials     3208     3202       -6     
Flag Coverage Δ
jsdom 52.80% <54.54%> (+0.05%) ⬆️
node 16.86% <54.54%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/editor/src/browser/breadcrumb/default.ts 51.85% <ø> (ø)
packages/editor/src/browser/types.ts 100.00% <ø> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
...kages/editor/src/browser/menu/breadcrumbs.menus.ts 50.00% <50.00%> (ø)
packages/core-browser/src/menu/next/menu-id.ts 100.00% <100.00%> (ø)
packages/utils/src/buffer.ts 29.65% <0.00%> (-4.07%) ⬇️
...src/browser/services/opened-editor-tree.service.ts 53.76% <0.00%> (-3.22%) ⬇️
packages/extension/src/common/extension.ts 83.80% <0.00%> (ø)
...es/extension/src/browser/extension-node.service.ts 24.17% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 added this pull request to the merge queue Mar 1, 2023
Merged via the queue into opensumi:main with commit 65e3835 Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants