Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support Trim Final NewLines configuration #2277

Merged
merged 2 commits into from
Feb 15, 2023
Merged

fix: support Trim Final NewLines configuration #2277

merged 2 commits into from
Feb 15, 2023

Conversation

pipiiiiii
Copy link
Contributor

Types

  • 🐛 Bug Fixes

Background or solution

#2218

Changelog

fix: 修复 Files > Trim Final Newlines 不生效问题

@github-actions github-actions bot added the 🐞 bug Something isn't working label Feb 13, 2023
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 57.77% // Head: 57.75% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (519b7b1) compared to base (42e488e).
Patch coverage: 19.29% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2277      +/-   ##
==========================================
- Coverage   57.77%   57.75%   -0.03%     
==========================================
  Files        1321     1321              
  Lines       83195    83251      +56     
  Branches    17319    17331      +12     
==========================================
+ Hits        48069    48079      +10     
- Misses      31927    31963      +36     
- Partials     3199     3209      +10     
Flag Coverage Δ
jsdom 52.72% <19.29%> (-0.03%) ⬇️
node 16.84% <19.29%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
...erences/src/browser/preference-settings.service.ts 72.19% <ø> (ø)
...s/editor/src/browser/doc-model/saveParticipants.ts 21.52% <19.29%> (-2.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pipiiiiii
Copy link
Contributor Author

/publish

@github-actions
Copy link
Contributor

🎉 PR Next version 2.22.3-next-1676289627.0 publish successful! You can install prerelease version via npm install package@2.22.3-next-1676289627.0 @pipiiiiii

2.22.3-next-1676289627.0

/home/runner/work/_temp/_runner_file_commands/step_summary_89f9bbad-3d3e-4314-a5ba-1eb2e6cc81b5

@pipiiiiii pipiiiiii changed the title fix: 修复 Files > Trim Final Newlines 不生效问题 fix: fix Files > Trim Final Newlines file perference is not useful Feb 14, 2023
@pipiiiiii pipiiiiii changed the title fix: fix Files > Trim Final Newlines file perference is not useful fix: Files > Trim Final Newlines file perference is not useful Feb 14, 2023
@erha19
Copy link
Member

erha19 commented Feb 15, 2023

@pipiiiiii 是否有录屏演示一下修复后功能? 另外标题可以优化一下,例如改成 fix: support Trim Final NewLines.. configuration

@pipiiiiii pipiiiiii changed the title fix: Files > Trim Final Newlines file perference is not useful fix: support Trim Final NewLines configuration Feb 15, 2023
@pipiiiiii
Copy link
Contributor Author

Kapture 2023-02-15 at 12 11 58

@erha19

@erha19 erha19 added this pull request to the merge queue Feb 15, 2023
Merged via the queue into main with commit f93e06d Feb 15, 2023
@erha19 erha19 deleted the fix/save-trim branch February 15, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants