Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: menubar component will reset focus after click #2284

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Conversation

pipiiiiii
Copy link
Contributor

Types

  • 🎉 New Features

Background or solution

Issue: #1814

Kapture 2023-02-14 at 15 29 52

Changelog

feat: menubar component will reset focus after click

@github-actions github-actions bot added the 🎨 feature feature required label Feb 14, 2023
Ricbet
Ricbet previously approved these changes Feb 14, 2023
Copy link
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

erha19
erha19 previously approved these changes Feb 14, 2023
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 57.77% // Head: 57.78% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (0429e32) compared to base (42e488e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2284   +/-   ##
=======================================
  Coverage   57.77%   57.78%           
=======================================
  Files        1321     1321           
  Lines       83195    83195           
  Branches    17319    17319           
=======================================
+ Hits        48069    48076    +7     
+ Misses      31927    31921    -6     
+ Partials     3199     3198    -1     
Flag Coverage Δ
jsdom 52.75% <ø> (+<0.01%) ⬆️
node 16.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/utils/src/buffer.ts 33.72% <0.00%> (+4.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pipiiiiii pipiiiiii dismissed stale reviews from erha19 and Ricbet via 0429e32 February 14, 2023 08:02
@erha19 erha19 added this pull request to the merge queue Feb 15, 2023
Merged via the queue into main with commit b09fc93 Feb 15, 2023
@erha19 erha19 deleted the feat/menu-focus branch February 15, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants