Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modified readonly logic of diff editor #2295

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Feb 16, 2023

Types

  • 🐛 Bug Fixes

Background or solution

monaco diff editor 的只读逻辑是根据 modified model 的 readonly 字段决定的,原先这里的逻辑并没有覆盖到

Changelog

修复 diff 视图下 modified model 的只读逻辑不生效的问题

@Ricbet Ricbet requested review from hacke2 and erha19 February 16, 2023 09:55
@Ricbet Ricbet self-assigned this Feb 16, 2023
@github-actions github-actions bot added the 🐞 bug Something isn't working label Feb 16, 2023
@Ricbet Ricbet linked an issue Feb 16, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 57.75% // Head: 57.75% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (6a1c6d9) compared to base (3d84700).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2295   +/-   ##
=======================================
  Coverage   57.75%   57.75%           
=======================================
  Files        1321     1321           
  Lines       83251    83253    +2     
  Branches    17331    17332    +1     
=======================================
+ Hits        48079    48086    +7     
+ Misses      31963    31959    -4     
+ Partials     3209     3208    -1     
Flag Coverage Δ
jsdom 52.72% <0.00%> (+<0.01%) ⬆️
node 16.84% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/editor/src/browser/editor-collection.service.ts 65.63% <0.00%> (-0.35%) ⬇️
packages/utils/src/buffer.ts 33.72% <0.00%> (+4.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ricbet Ricbet added this pull request to the merge queue Feb 17, 2023
Merged via the queue into main with commit 0dd0be5 Feb 17, 2023
@Ricbet Ricbet deleted the fix/diff-editor-modifiedModel branch February 17, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error when save diff files which on the staged changes
2 participants