Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add margins to the QuickOpen input #2299

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

wangxiaojuan
Copy link
Contributor

@wangxiaojuan wangxiaojuan commented Feb 17, 2023

Types

  • 🐛 Bug Fixes

Background or solution

image

fixed #1742

Changelog

修复 QuickPick 面板 Input上下无间距的问题

@github-actions github-actions bot added the 🐞 bug Something isn't working label Feb 17, 2023
@wangxiaojuan wangxiaojuan changed the title fix: 修复 QuickPick 面板 Input上下无间距的问题 fix: 修复 QuickPick 面板 Input上下无间距的问题 fixed #1742 Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 57.75% // Head: 57.75% // No change to project coverage 👍

Coverage data is based on head (50ecf58) compared to base (f35fe97).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2299   +/-   ##
=======================================
  Coverage   57.75%   57.75%           
=======================================
  Files        1322     1322           
  Lines       83269    83269           
  Branches    17330    17330           
=======================================
  Hits        48092    48092           
  Misses      31969    31969           
  Partials     3208     3208           
Flag Coverage Δ
jsdom 52.72% <ø> (ø)
node 16.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 changed the title fix: 修复 QuickPick 面板 Input上下无间距的问题 fixed #1742 fix: 修复 QuickPick 面板 Input上下无间距的问题 Feb 17, 2023
@wangxiaojuan wangxiaojuan changed the title fix: 修复 QuickPick 面板 Input上下无间距的问题 fix: no space between the top and bottom of the Input of the QuickPick panel Feb 17, 2023
@erha19 erha19 changed the title fix: no space between the top and bottom of the Input of the QuickPick panel fix: add margins to the QuickOpen input Feb 17, 2023
@erha19 erha19 added this pull request to the merge queue Feb 17, 2023
Merged via the queue into opensumi:main with commit b12f645 Feb 17, 2023
@erha19 erha19 added this to the 2.23 milestone Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] QuickPick 面板一些样式问题
2 participants