Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read-only resource render lock icon #2309

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Feb 20, 2023

Types

  • 🎉 New Features

Background or solution

code editor
image

diff editor
image

Changelog

只读文件的 tab 增加 lock 图标

@github-actions github-actions bot added the 🎨 feature feature required label Feb 20, 2023
@Ricbet Ricbet self-assigned this Feb 20, 2023
@Ricbet Ricbet linked an issue Feb 20, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 52.73% // Head: 57.76% // Increases project coverage by +5.02% 🎉

Coverage data is based on head (73c7ad1) compared to base (e580012).
Patch coverage: 71.42% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2309      +/-   ##
==========================================
+ Coverage   52.73%   57.76%   +5.02%     
==========================================
  Files        1322     1322              
  Lines       83271    83276       +5     
  Branches    17331    17332       +1     
==========================================
+ Hits        43914    48105    +4191     
+ Misses      35725    31962    -3763     
+ Partials     3632     3209     -423     
Flag Coverage Δ
jsdom 52.73% <71.42%> (+<0.01%) ⬆️
node 16.84% <28.57%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tor/src/browser/doc-model/editor-document-model.ts 55.90% <ø> (ø)
packages/editor/src/browser/doc-model/types.ts 100.00% <ø> (ø)
packages/editor/src/browser/resource.service.ts 85.51% <ø> (ø)
packages/editor/src/common/resource.ts 100.00% <ø> (ø)
...es/editor/src/browser/editor-collection.service.ts 65.56% <71.42%> (-0.08%) ⬇️
...ges/editor/src/browser/workbench-editor.service.ts 59.29% <0.00%> (+0.08%) ⬆️
packages/utils/src/buffer.ts 29.65% <0.00%> (+0.58%) ⬆️
packages/core-common/src/types/editor.ts 21.05% <0.00%> (+1.75%) ⬆️
packages/core-common/src/log.ts 91.46% <0.00%> (+3.65%) ⬆️
...ages/file-service/src/node/file-service-watcher.ts 80.90% <0.00%> (+4.02%) ⬆️
... and 101 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 added this pull request to the merge queue Feb 21, 2023
Merged via the queue into main with commit ea6688e Feb 21, 2023
@erha19 erha19 deleted the feat/render-readonly-icon branch February 21, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 改进优化: 对于只读的文件可以加个图标标识
2 participants