Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support normal prelunchTask on debug #2330

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Feb 23, 2023

Types

  • 🐛 Bug Fixes

Background or solution

close #2321.

对齐 Task Label 格式,以兼容 VS Code 下可正常使用的 Task 命令声明

Changelog

support normal prelunchTask on debug

@github-actions github-actions bot added the 🐞 bug Something isn't working label Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 57.77% // Head: 57.76% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (403a226) compared to base (ea6688e).
Patch coverage: 7.69% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2330      +/-   ##
==========================================
- Coverage   57.77%   57.76%   -0.01%     
==========================================
  Files        1322     1322              
  Lines       83276    83275       -1     
  Branches    17332    17332              
==========================================
- Hits        48112    48105       -7     
- Misses      31956    31961       +5     
- Partials     3208     3209       +1     
Flag Coverage Δ
jsdom 52.73% <7.69%> (-0.01%) ⬇️
node 16.84% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/debug/src/browser/debug-session-manager.ts 66.33% <0.00%> (ø)
.../src/browser/view/console/debug-console.service.ts 15.42% <0.00%> (+0.07%) ⬆️
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
...rc/browser/contextkeys/debug-contextkey.service.ts 100.00% <100.00%> (ø)
packages/utils/src/buffer.ts 29.65% <0.00%> (-4.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 added this pull request to the merge queue Feb 23, 2023
Merged via the queue into main with commit 9fa7c3e Feb 23, 2023
@erha19 erha19 deleted the fix/change-task-label-format branch February 23, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The debug action Playwright Current File doesn't worked on OpenSumi IDE
2 participants