Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: editor tab title display file path #2343

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Conversation

hacke2
Copy link
Member

@hacke2 hacke2 commented Feb 28, 2023

Types

  • 🎉 New Features

Background or solution

resolve #2296

file resource:

image

diff resource:

image

Changelog

feat: editor tab title display file path

@github-actions github-actions bot added the 🎨 feature feature required label Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage: 83.78% and no project coverage change

Comparison is base (9544725) 57.83% compared to head (0c91317) 57.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2343   +/-   ##
=======================================
  Coverage   57.83%   57.83%           
=======================================
  Files        1322     1323    +1     
  Lines       83236    83295   +59     
  Branches    17333    17348   +15     
=======================================
+ Hits        48139    48175   +36     
- Misses      31895    31916   +21     
- Partials     3202     3204    +2     
Flag Coverage Δ
jsdom 52.80% <83.78%> (+<0.01%) ⬆️
node 16.70% <5.40%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/editor/src/common/resource.ts 100.00% <ø> (ø)
...ages/editor/src/browser/fs-resource/fs-resource.ts 69.79% <82.35%> (+1.37%) ⬆️
packages/editor/src/browser/diff/index.ts 90.56% <85.00%> (-3.72%) ⬇️
packages/core-browser/src/utils/env.ts 25.00% <0.00%> (-31.25%) ⬇️
...ser/components/scm-resource-tree/scm-tree-model.ts 38.46% <0.00%> (-4.40%) ⬇️
...kages/search/src/browser/tree/tree-node.defined.ts 57.89% <0.00%> (-3.22%) ⬇️
...s/extension/src/browser/vscode/contributes/menu.ts 49.33% <0.00%> (-2.44%) ⬇️
...wser/components/scm-resource-tree/scm-tree-node.ts 23.94% <0.00%> (-0.35%) ⬇️
...kages/components/src/recycle-tree/tree/TreeNode.ts 68.35% <0.00%> (-0.29%) ⬇️
...ges/editor/src/browser/workbench-editor.service.ts 59.24% <0.00%> (-0.06%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Ricbet
Ricbet previously approved these changes Mar 1, 2023
Copy link
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

erha19
erha19 previously approved these changes Mar 3, 2023
@erha19 erha19 merged commit 4252ef0 into main Mar 7, 2023
@erha19 erha19 deleted the feat/editor-tab-title branch March 7, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 标签页 hover 上去展示该文件的完整路径
3 participants