Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show theme quick picker after theme extension installed #2398

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

PerfectPan
Copy link
Contributor

Types

  • ๐ŸŽ‰ New Features
  • ๐Ÿ› Bug Fixes
  • ๐Ÿ“š Documentation Changes
  • ๐Ÿ’„ Code Style Changes
  • ๐Ÿ’„ Style Changes
  • ๐Ÿชš Refactors
  • ๐Ÿš€ Performance Improvements
  • ๐Ÿ—๏ธ Build System
  • โฑ Tests
  • ๐Ÿงน Chores
  • Other Changes

Background or solution

fix #1232

Changelog

show theme quick picker after theme extension installed

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the ๐Ÿž bug Something isn't working label Mar 12, 2023
Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

้ชŒ่ฏ้€š่ฟ‡๏ผŒๅŠŸ่ƒฝไธŽ้ข„ๆœŸไธ€่‡ด

packages/i18n/src/common/en-US.lang.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +5.00 ๐ŸŽ‰

Comparison is base (4c0ec0a) 52.79% compared to head (b431db8) 57.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2398      +/-   ##
==========================================
+ Coverage   52.79%   57.80%   +5.00%     
==========================================
  Files        1323     1323              
  Lines       83295    83328      +33     
  Branches    17348    17362      +14     
==========================================
+ Hits        43979    48170    +4191     
+ Misses      35687    31945    -3742     
+ Partials     3629     3213     -416     
Flag Coverage ฮ”
jsdom 52.83% <50.00%> (+0.03%) โฌ†๏ธ
node 16.69% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage ฮ”
...s/extension/src/browser/vscode/contributes/icon.ts 30.23% <รธ> (รธ)
.../extension/src/browser/vscode/contributes/theme.ts 100.00% <รธ> (รธ)
packages/i18n/src/common/en-US.lang.ts 100.00% <รธ> (รธ)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <รธ> (รธ)
packages/theme/src/common/theme.service.ts 67.94% <รธ> (รธ)
...ension/src/browser/extension-management.service.ts 43.67% <42.85%> (-0.92%) โฌ‡๏ธ
packages/theme/src/browser/icon.service.ts 76.49% <100.00%> (รธ)
...kages/theme/src/browser/workbench.theme.service.ts 71.96% <100.00%> (รธ)

... and 120 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 3455b10 into opensumi:main Mar 15, 2023
@erha19
Copy link
Member

erha19 commented Mar 15, 2023

@PerfectPan ๆ„Ÿ่ฐขไฝ ็š„่ดก็Œฎ๏ผŒๅŽ็ปญไปฃ็ ๅฐ†ไผšๅœจ v2.23.0 ็‰ˆๆœฌไธญๅ‘ๅธƒ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿž bug Something isn't working
Projects
None yet
3 participants