-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: namespace conflicts between extHost and extBrowser #2415
Conversation
ChatGPT Code Review: 对代码进行 CodeReview 可以从以下几个方面入手:
对于这份代码,比较明显的问题是:
参考下面的 commit message 修改代码并提交: feat(debug): use ILogger instead of ILogServiceClient replace ILogServiceClient with ILogger in 3 files to avoid namespace conflicts Signed-off-by: your name you@example.com |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2415 +/- ##
=======================================
Coverage 57.81% 57.82%
=======================================
Files 1323 1322 -1
Lines 83315 83324 +9
Branches 17360 17361 +1
=======================================
+ Hits 48165 48178 +13
+ Misses 31939 31934 -5
- Partials 3211 3212 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
packages/extension/src/browser/vscode/api/debug/extension-debug-service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/publish |
🎉 PR Next version 2.22.9-next-1679025716.0 publish successful! You can install prerelease version via
/home/runner/work/_temp/_runner_file_commands/step_summary_1cb4d9ce-17ea-4b38-8bf3-0fa3666b68c2 |
Types
Background or solution
一般情况下,插件进程的日志会写入到 logDir/20230315/extHost.log 文件中,但由于 OpenSumi 在插件实现上有自己的 browser 层,会导致情况特殊,browser 写入的日志是通过 Node 进程写入的。
插件中 browser 层的日志是通过 Node 进程也同时写入到 extHost.log 中,在两个进程同时打开文件句柄,会导致 Windows 环境下的写锁保护机制报错,导致日志写入失败。
解决方法:插件的 Browser 使用另外一个命名空间,和插件进程区分开,保证不同的集成不会写入同一个文件,同时也能保证逻辑清晰。
closed #2383
Changelog
修复插件浏览器层的日志和插件进程的命名空间冲突