Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure outline is displayed properly #2440

Merged
merged 9 commits into from
Mar 20, 2023
Merged

fix: ensure outline is displayed properly #2440

merged 9 commits into from
Mar 20, 2023

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented Mar 17, 2023

Types

  • 🐛 Bug Fixes

Background or solution

尝试修了一些 Outline Model 上存在的问题:
以前:
demo

现在:

CleanShot.2023-03-17.at.16.26.54.mp4

Changelog

ensure outline is displayed properly

@bytemain bytemain changed the base branch from main to v2.22 March 17, 2023 03:01
@github-actions github-actions bot added the ⚙️ refactor Refactor code label Mar 17, 2023
erha19
erha19 previously approved these changes Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v2.22@5f9389b). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##             v2.22    #2440   +/-   ##
========================================
  Coverage         ?   57.75%           
========================================
  Files            ?     1319           
  Lines            ?    83293           
  Branches         ?    17332           
========================================
  Hits             ?    48107           
  Misses           ?    31976           
  Partials         ?     3210           
Flag Coverage Δ
jsdom 52.78% <0.00%> (?)
node 16.74% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bytemain bytemain changed the title refactor: use lru map to dispose outline model WIP: refactor: use lru map to dispose outline model Mar 17, 2023
@bytemain bytemain changed the title WIP: refactor: use lru map to dispose outline model fix: ensure outline is displayed properly Mar 17, 2023
@github-actions github-actions bot added the 🐞 bug Something isn't working label Mar 17, 2023
@opensumi opensumi deleted a comment from github-actions bot Mar 17, 2023
@erha19 erha19 changed the base branch from v2.22 to main March 20, 2023 02:33
@erha19 erha19 dismissed their stale review March 20, 2023 02:33

The base branch was changed.

@erha19 erha19 merged commit 2fcf871 into main Mar 20, 2023
@erha19 erha19 deleted the fix/outline/no-info branch March 20, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working ⚙️ refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants