Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support skipFiles on debug call stack frames view #2468

Merged
merged 4 commits into from
Mar 27, 2023

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Mar 22, 2023

Types

  • 🎉 New Features

Background or solution

image

close #2445

Changelog

support skipFiles on debug call stack frames view

@erha19 erha19 requested a review from Ricbet March 22, 2023 10:40
@erha19
Copy link
Member Author

erha19 commented Mar 22, 2023

/publish

@github-actions github-actions bot added the 🎨 feature feature required label Mar 22, 2023
@github-actions
Copy link
Contributor

🎉 PR Next version 2.23.1-next-1679481979.0 publish successful! You can install prerelease version via npm install package@2.23.1-next-1679481979.0 @erha19

2.23.1-next-1679481979.0

/home/runner/work/_temp/_runner_file_commands/step_summary_0ee25e62-eb04-443c-9daa-f9b7254da376

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 13.33% and project coverage change: -0.01 ⚠️

Comparison is base (42e2718) 57.74% compared to head (f0925d4) 57.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2468      +/-   ##
==========================================
- Coverage   57.74%   57.73%   -0.01%     
==========================================
  Files        1323     1323              
  Lines       83471    83486      +15     
  Branches    17374    17376       +2     
==========================================
+ Hits        48198    48200       +2     
- Misses      32051    32064      +13     
  Partials     3222     3222              
Flag Coverage Δ
jsdom 52.75% <13.33%> (-0.01%) ⬇️
node 16.75% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
...kages/debug/src/browser/model/debug-stack-frame.ts 46.15% <13.33%> (-9.85%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19
Copy link
Member Author

erha19 commented Mar 23, 2023

完整效果:

Kapture.2023-03-23.at.10.18.39.mp4

@erha19
Copy link
Member Author

erha19 commented Mar 23, 2023

/publish

@github-actions
Copy link
Contributor

🎉 PR Next version 2.23.1-next-1679538359.0 publish successful! You can install prerelease version via npm install package@2.23.1-next-1679538359.0 @erha19

2.23.1-next-1679538359.0

/home/runner/work/_temp/_runner_file_commands/step_summary_3a80c36c-3495-4f89-9655-2bc71312dd34

@erha19
Copy link
Member Author

erha19 commented Mar 23, 2023

/publish

@github-actions
Copy link
Contributor

🎉 PR Next version 2.23.1-next-1679540198.0 publish successful! You can install prerelease version via npm install package@2.23.1-next-1679540198.0 @erha19

2.23.1-next-1679540198.0

/home/runner/work/_temp/_runner_file_commands/step_summary_1ccbdd35-8f6f-412e-b68b-8253c3fe09b4

@geekeren
Copy link
Contributor

image
@erha19 未知源 会出现两个 skipFiles ,点击后 还是有两个 skipFiles 符合预期吗

@erha19
Copy link
Member Author

erha19 commented Mar 23, 2023

/publish

@github-actions
Copy link
Contributor

🎉 PR Next version 2.23.1-next-1679557802.0 publish successful! You can install prerelease version via npm install package@2.23.1-next-1679557802.0 @erha19

2.23.1-next-1679557802.0

/home/runner/work/_temp/_runner_file_commands/step_summary_578d36b8-7ddb-4f47-a4ba-daba6a0b09a4

@erha19
Copy link
Member Author

erha19 commented Mar 23, 2023

/publish

@github-actions
Copy link
Contributor

🎉 PR Next version 2.23.1-next-1679565831.0 publish successful! You can install prerelease version via npm install package@2.23.1-next-1679565831.0 @erha19

2.23.1-next-1679565831.0

/home/runner/work/_temp/_runner_file_commands/step_summary_2218ea16-122e-4c0a-8995-861894d96e32

Copy link
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 536da6d into main Mar 27, 2023
@erha19 erha19 deleted the feat/support-skip-files branch March 27, 2023 02:16
@erha19 erha19 added this to the 2.24 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Debug skipFiles 选项不生效
3 participants