Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export localizationRegistryMap #2482

Merged
merged 1 commit into from
Mar 23, 2023
Merged

chore: export localizationRegistryMap #2482

merged 1 commit into from
Mar 23, 2023

Conversation

miserylee
Copy link
Contributor

@miserylee miserylee commented Mar 23, 2023

Types

在开发时可能需要列出一下正在使用的语言包,方便查看当前系统已经在使用的 scope、key,重载文案的时候作为参考

  • 🧹 Chores

Background or solution

Changelog

@CLAassistant
Copy link

CLAassistant commented Mar 23, 2023

CLA assistant check
All committers have signed the CLA.

@miserylee miserylee changed the title 导出 'localizationRegistryMap' feat: 导出 'localizationRegistryMap' Mar 23, 2023
@github-actions github-actions bot added the 🎨 feature feature required label Mar 23, 2023
@bytemain bytemain changed the title feat: 导出 'localizationRegistryMap' chore: export localizationRegistryMap Mar 23, 2023
@bytemain bytemain removed the 🎨 feature feature required label Mar 23, 2023
Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f1741b2) 57.74% compared to head (e8663db) 57.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2482   +/-   ##
=======================================
  Coverage   57.74%   57.74%           
=======================================
  Files        1323     1323           
  Lines       83471    83471           
  Branches    17374    17374           
=======================================
  Hits        48198    48198           
  Misses      32051    32051           
  Partials     3222     3222           
Flag Coverage Δ
jsdom 52.76% <100.00%> (ø)
node 16.75% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-common/src/localize.ts 98.61% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit bd10eba into opensumi:main Mar 23, 2023
@erha19 erha19 added this to the 2.24 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants