Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix ext-host editors error on closing diff editors #251

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

MMhunter
Copy link
Contributor

Types

  • 馃悰 Bug Fixes

image

Background or solution

Wrong removed changes were push to extension host after closing diffEditors, causing TextEditor without TextDocument kept in workspace.textEditors.

Changelog

  • fixes editor features failing after closing diffEditors.

@codecov-commenter
Copy link

Codecov Report

Merging #251 (6b1788b) into main (76976cf) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
- Coverage   59.27%   59.26%   -0.01%     
==========================================
  Files        1181     1181              
  Lines       72663    72663              
  Branches    15060    15060              
==========================================
- Hits        43068    43065       -3     
- Misses      26972    26974       +2     
- Partials     2623     2624       +1     
Impacted Files Coverage 螖
...nsion/src/browser/vscode/api/main.thread.editor.ts 44.83% <酶> (酶)
packages/monaco/src/browser/schema-registry.ts 68.88% <0.00%> (-2.23%) 猬囷笍
...kages/theme/src/browser/workbench.theme.service.ts 70.32% <0.00%> (-0.90%) 猬囷笍
...erences/src/browser/preference-settings.service.ts 79.16% <0.00%> (-0.70%) 猬囷笍
packages/core-common/src/node/port.ts 46.96% <0.00%> (+3.03%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 76976cf...6b1788b. Read the comment docs.

Copy link
Member

@hacke2 hacke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Aaaaash Aaaaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants