Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: work host env 增加 language #2532

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

winjo
Copy link
Contributor

@winjo winjo commented Mar 30, 2023

Types

  • 🎉 New Features
  • 🐛 Bug Fixes
  • 📚 Documentation Changes
  • 💄 Code Style Changes
  • 💄 Style Changes
  • 🪚 Refactors
  • 🚀 Performance Improvements
  • 🏗️ Build System
  • ⏱ Tests
  • 🧹 Chores
  • Other Changes

Background or solution

close: #2531

Changelog

worker-host env 增加 language 属性

@winjo winjo requested a review from Ricbet March 30, 2023 12:53
@github-actions github-actions bot added the 🎨 feature feature required label Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8446313) 57.72% compared to head (8435323) 57.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2532   +/-   ##
=======================================
  Coverage   57.72%   57.72%           
=======================================
  Files        1322     1322           
  Lines       83447    83449    +2     
  Branches    17361    17361           
=======================================
+ Hits        48168    48171    +3     
+ Misses      32056    32055    -1     
  Partials     3223     3223           
Flag Coverage Δ
jsdom 52.74% <100.00%> (+<0.01%) ⬆️
node 16.75% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/src/hosted/api/vscode/env/workerEnvApiFactory.ts 63.63% <100.00%> (+8.08%) ⬆️
...sion/src/hosted/api/worker/worker.host.api.impl.ts 94.87% <100.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@winjo winjo merged commit 9118e93 into main Mar 31, 2023
@winjo winjo deleted the feat/work-host-env-language branch March 31, 2023 03:33
@erha19 erha19 added this to the 2.24 milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] worker-host env 增加 language 属性
3 participants