Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rewrite some logs message and add not-chinese-message commit rule #2542

Merged
merged 4 commits into from
Apr 6, 2023

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Apr 3, 2023

Types

  • 🧹 Chores

Background or solution

追加对于 Commit 信息的非中文语法校验

image

重写部分日志信息为英文

Changelog

rewrite some logs message and add not-chinese-message commit rule

@erha19 erha19 requested review from bytemain and Ricbet April 3, 2023 04:17
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 18.18% and no project coverage change.

Comparison is base (a801110) 57.72% compared to head (339d50d) 57.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2542   +/-   ##
=======================================
  Coverage   57.72%   57.72%           
=======================================
  Files        1324     1324           
  Lines       83545    83544    -1     
  Branches    17382    17392   +10     
=======================================
  Hits        48227    48227           
+ Misses      32089    32088    -1     
  Partials     3229     3229           
Flag Coverage Δ
jsdom 52.74% <18.18%> (+<0.01%) ⬆️
node 16.76% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/core-common/src/di-helper/domain-helper.ts 66.66% <0.00%> (ø)
...tor/src/browser/doc-model/editor-document-model.ts 55.90% <0.00%> (ø)
...owser/monaco-contrib/tokenizer/textmate.service.ts 18.75% <0.00%> (ø)
packages/editor/src/browser/untitled-resource.ts 42.69% <ø> (ø)
...ges/editor/src/browser/workbench-editor.service.ts 59.24% <ø> (ø)
...s/extension/src/browser/sumi/main.thread.layout.ts 18.03% <0.00%> (-0.31%) ⬇️
...ion/src/browser/vscode/contributes/localization.ts 63.79% <0.00%> (ø)
...es/file-service/src/browser/file-service-client.ts 74.40% <0.00%> (ø)
packages/file-service/src/node/file-service.ts 80.70% <0.00%> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit ec4dea4 into main Apr 6, 2023
11 checks passed
@erha19 erha19 deleted the chore/add-not-chinese-message-rules branch April 6, 2023 02:38
@erha19 erha19 added this to the 2.24 milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants