Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: menubar supports compact mode #2556

Merged
merged 4 commits into from
Apr 14, 2023
Merged

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Apr 6, 2023

Types

  • 🎉 New Features

Background or solution

image

Changelog

menubar 支持 compact 模式

@Ricbet Ricbet self-assigned this Apr 6, 2023
@Ricbet Ricbet linked an issue Apr 6, 2023 that may be closed by this pull request
@opensumi opensumi bot added the 🎨 feature feature required label Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage: 88.23% and no project coverage change.

Comparison is base (97652f3) 57.62% compared to head (0265011) 57.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2556   +/-   ##
=======================================
  Coverage   57.62%   57.62%           
=======================================
  Files        1326     1326           
  Lines       83566    83578   +12     
  Branches    17399    17399           
=======================================
+ Hits        48151    48161   +10     
- Misses      32173    32175    +2     
  Partials     3242     3242           
Flag Coverage Δ
jsdom 52.64% <88.23%> (+<0.01%) ⬆️
node 16.76% <23.52%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-browser/src/core-preferences.ts 92.85% <ø> (ø)
...ackages/core-browser/src/extensions/schema/menu.ts 100.00% <ø> (ø)
packages/i18n/src/common/contributes/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/contributes/zh-CN.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
...s/main-layout/src/common/main-layout.definition.ts 100.00% <ø> (ø)
...erences/src/browser/preference-settings.service.ts 72.19% <ø> (ø)
packages/menu-bar/src/browser/menu-bar.store.ts 93.02% <80.00%> (-4.20%) ⬇️
packages/core-browser/src/menu/next/menu-id.ts 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

packages/menu-bar/src/browser/menu-bar.contribution.ts Outdated Show resolved Hide resolved
tools/electron/src/browser/layout.ts Outdated Show resolved Hide resolved
@Ricbet Ricbet force-pushed the feat/support-menubar-compact-mode branch from 1a18d7f to 0265011 Compare April 12, 2023 02:29
@erha19 erha19 merged commit 9eec034 into main Apr 14, 2023
11 checks passed
@erha19 erha19 deleted the feat/support-menubar-compact-mode branch April 14, 2023 09:27
@erha19 erha19 added this to the 2.24 milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] menubar 支持 compact 模式
2 participants