fix(core-browser): move react to peerDependencies

[gemwuu]

Types

• 🎉 New Features
• 🐛 Bug Fixes
• 📚 Documentation Changes
• 💄 Code Style Changes
• 💄 Style Changes
• 🪚 Refactors
• 🚀 Performance Improvements
• 🏗️ Build System
• ⏱ Tests
• 🧹 Chores
• Other Changes

Background or solution

@opensumi/ide-core-browser depends on react@^16.8.6, which should be put in peerDependencies to avoid creating extra unnecessary react@16.x environment.

Changelog

fix(core-browser): move react to peerDependencies.

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[hacke2]

/publish

[github-actions]

🎉 PR Next version 2.23.3-next-1680847428.0 publish successful! You can install prerelease version via npm install package@2.23.3-next-1680847428.0 @hacke2

2.23.3-next-1680847428.0

/home/runner/work/_temp/_runner_file_commands/step_summary_4cd034eb-fc9b-4e56-91ce-7b6b6d1da056

[bytemain]

请再重新提交一下 lock 文件

[gemwuu]

请再重新提交一下 lock 文件

提交了，麻烦再触发下 CI。

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (c1c06c5) 57.72% compared to head (6bd56b3) 57.72%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2562   +/-   ##
=======================================
  Coverage   57.72%   57.72%           
=======================================
  Files        1324     1324           
  Lines       83544    83544           
  Branches    17392    17392           
=======================================
+ Hits        48222    48228    +6     
+ Misses      32092    32087    -5     
+ Partials     3230     3229    -1     

Flag	Coverage Δ
jsdom	52.74% <ø> (+<0.01%)	⬆️
node	16.76% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[hacke2]

/publish

[github-actions]

🎉 PR Next version 2.23.3-next-1680851880.0 publish successful! You can install prerelease version via npm install package@2.23.3-next-1680851880.0 @hacke2

2.23.3-next-1680851880.0

/home/runner/work/_temp/_runner_file_commands/step_summary_1f2c1647-d290-40d9-951d-173ac8d6e331

[erha19]

@gemwuu @hacke2 这个有相关结论吗？移动 react 依赖到 DevDeps 的原因是啥？

[gemwuu]

@gemwuu @hacke2 这个有相关结论吗？移动 react 依赖到 DevDeps 的原因是啥？

是移到 peerDependencies 中。组件强依赖 react 框架，更加合理的做法是声明 peerDependencies，否则会污染依赖树上的 react 版本。

[hacke2]

LGTM

[erha19]

LGTM, @Ricbet 也看一下吧