-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support maxResize props on the panel #2569
Conversation
ChatGPT Code Review: CodeReview:
修改建议:
合适的 commit message: feat(recycle-tree): add support maxResize props on the panel fix(left-panel): adjust the minResize value to 280 to avoid too small fix(right-panel): add the maxResize value to 480 to limit the size of the panel refactor(StatusBar): avoid rendering blank areas by checking the length of the left/right Entries chore: update the code format |
/publish |
🎉 PR Next version 2.23.3-next-1681122616.0 publish successful! You can install prerelease version via
/home/runner/work/_temp/_runner_file_commands/step_summary_ffd846c1-c180-4e9f-a87b-9f2855dc863b |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2569 +/- ##
=======================================
Coverage 57.71% 57.71%
=======================================
Files 1324 1324
Lines 83544 83544
Branches 17392 17392
=======================================
Hits 48221 48221
Misses 32093 32093
Partials 3230 3230
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Types
Background or solution
🤖 Generated by Copilot at d27eae1
isDisposed
to check if theRecycleTreeBasic
component is unmounted before updating the state (link,link,link)minResize
andmaxResize
props of theSplitPanel
component in theDefaultLayout
andToolbarActionBasedLayout
components, which control the layout of the left and right panels, to allow resizing between 280px and 480px (link,link,link,link)data-max-resize
to theSplitPanel
component, which stores the maximum resize value of each panel element (link)ResizeHandleHorizontal
component, which handles the horizontal resizing of the panels, to avoid errors and limit resizing (link,link)flexModeSetSize
function in theResizeHandleHorizontal
component, which sets the size of the fixed and flex elements in the flex mode, to simplify the logic and use constants (link)SplitPanel
component, for readability and consistency (link,link)StatusBarView
component, which renders the status bar items, to avoid rendering an empty array as a child element (link)SplitPanel
andStatusBarView
component files, for code style consistency (link,link)close #2537
在侧边栏默认大小控制方面,还可以通过
AppConfig#panelSize
的方式去控制。相关逻辑见:core/packages/main-layout/src/browser/tabbar/panel.view.tsx
Line 48 in 19ad0bf
同时修复骨架图下面的
0 0
奇怪样式Changelog
support maxResize props on the panel and fix some warnings