-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): editor save code action notify configuration #2580
feat(editor): editor save code action notify configuration #2580
Conversation
/publish |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2580 +/- ##
=======================================
Coverage 57.62% 57.62%
=======================================
Files 1326 1326
Lines 83566 83559 -7
Branches 17399 17402 +3
=======================================
+ Hits 48151 48154 +3
+ Misses 32173 32166 -7
+ Partials 3242 3239 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@erha19 已修改文字描述 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
功能验证正常, @Ricbet 也看一下吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Types
Background or solution
编辑器模块执行saveCodeActions时默认会弹出Notification提示,新增配置可选是否弹窗提示。
🤖 Generated by Copilot at d1fc800
editor.codeActionsOnSaveNotification
to control the notification of code actions on save (link, link, link, link, link)runActions
insaveParticipants.ts
(link)runActions
to handle the case when the notification preference is false (link)schema.ts
(link)en-US.lang.ts
andzh-CN.lang.ts
(link, link, link, link)preferenceSettingsService
inpreference-settings.service.ts
(link)Changelog
🤖 Generated by Copilot at d1fc800
This pull request adds a new preference option to control the notification behavior of code actions on save in the editor. It also updates the localization files and the preference UI to support the new option. It refactors and fixes some code related to save participants in
saveParticipants.ts
.