-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rpcProtocol add timeout control #2587
Conversation
ChatGPT Code Review: CodeReview:
建议:
生成的 commit message: feat(connection): add timeout control in RPCProtocol 新增 RPCProtocol 的超时控制功能,通过设置 timeout 属性来控制 RPC请求的超时时间。超时时间到达后,会reject请求的回调函数,并清除回调函数和定时器句柄,有效避免了请求过程中一直等待回调,导致阻塞进程的情况出现。 |
/publish |
🎉 PR Next version 2.23.4-next-1681455781.0 publish successful! You can install prerelease version via
/home/runner/work/_temp/_runner_file_commands/step_summary_9c44528b-7a15-4657-850a-d8f297e57564 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需求的背景感觉可以补充一下
38dff51
to
64616e3
Compare
64616e3
to
8290935
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2587 +/- ##
==========================================
+ Coverage 57.62% 57.64% +0.01%
==========================================
Files 1326 1327 +1
Lines 83559 83615 +56
Branches 17402 17417 +15
==========================================
+ Hits 48154 48202 +48
- Misses 32166 32175 +9
+ Partials 3239 3238 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 24 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
7e8a162
to
fb76c14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Types
Background or solution
🤖 Generated by Copilot at 1a6b4dd
Issue: #2547
Changelog
🤖 Generated by Copilot at 1a6b4dd
Add timeout support to RPC protocol in
rpcProtocol.ts
. This enables rejecting RPC calls that take too long to respond and avoiding potential resource leaks.